Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump codecov-action from v1 to v2 in ci.yml #1492

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Bump codecov-action from v1 to v2 in ci.yml #1492

merged 1 commit into from
Mar 9, 2022

Conversation

fxamacker
Copy link
Member

Description

Bump to v2 because codecov-action@v1 is deprecated and can stop working.

See https://github.com/codecov/codecov-action#%EF%B8%8F--deprecration-of-v1

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Bump codecov-action from v1 to v2
51b02b2 
Bump to v2 because codecov-action@v1 is deprecated and can stop working.
@fxamacker fxamacker self-assigned this Mar 9, 2022
@fxamacker fxamacker requested a review from dsainati1 as a code owner March 9, 2022 17:56
@turbolent turbolent added the Chore label Mar 9, 2022
turbolent
turbolent approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit a882c95
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.65ms ±23%1.45ms ±28%~(p=0.165 n=7+7)
RuntimeResourceDictionaryValues-218.2ms ± 5%17.9ms ± 7%~(p=0.620 n=7+7)
ParseFungibleToken-2240µs ± 5%240µs ± 9%~(p=0.945 n=6+7)
ParseDeploy/byte_array-232.5ms ± 9%31.7ms ±22%~(p=0.535 n=7+7)
ParseDeploy/decode_hex-21.49ms ± 3%1.46ms ± 3%~(p=0.128 n=7+7)
ParseArray-219.8ms ± 6%18.7ms ±15%~(p=0.165 n=7+7)
ParseInfix-211.0µs ± 4%10.5µs ±12%~(p=0.209 n=7+7)
QualifiedIdentifierCreation/One_level-22.90ns ± 5%2.84ns ± 6%~(p=0.301 n=7+7)
QualifiedIdentifierCreation/Three_levels-2182ns ± 4%176ns ± 6%~(p=0.259 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2172µs ± 5%167µs ± 9%~(p=0.165 n=7+7)
ContractInterfaceFungibleToken-254.0µs ± 9%51.7µs ±11%~(p=0.209 n=7+7)
NewInterpreter/new_interpreter-21.52µs ± 8%1.43µs ± 5%~(p=0.053 n=7+7)
NewInterpreter/new_sub-interpreter-22.85µs ± 5%2.84µs ± 9%~(p=1.000 n=6+7)
InterpretRecursionFib-23.57ms ± 4%3.44ms ± 4%−3.61%(p=0.026 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=0.710 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.805 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=1.000 n=7+7)
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%~(p=0.409 n=7+7)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.32kB ± 0%1.32kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.52k ± 0%4.52k ± 0%~(p=0.297 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.789 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-239.0 ± 0%39.0 ± 0%~(all equal)
 

@turbolent turbolent merged commit 8c098cb into master Mar 9, 2022
@turbolent turbolent deleted the fxamacker/bump-codecov-action-to-v2 branch March 9, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@fxamacker fxamacker

Labels
Chore Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent